bash-it icon indicating copy to clipboard operation
bash-it copied to clipboard

tests: Use git worktree correctly

Open NoahGorny opened this issue 2 years ago • 3 comments

git worktree -d does not work on all versions of git worktree

this seems to resolve my problems running the tests locally

Description

After debugging the tests_setup a bit, I found out that git worktree call failed. After further testing, it seems like the -d flag was responsible for the failures

Motivation and Context

Closes #2115

How Has This Been Tested?

By running the tests :)

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

NoahGorny avatar Mar 08 '22 18:03 NoahGorny

nope, seems like there is something else in play here

NoahGorny avatar Mar 08 '22 20:03 NoahGorny

nope, seems like there is something else in play here

Hey, @NoahGorny I tried testing on Monterey and didn't get any errors. Could it be specific to big sur?

tbhaxor avatar Mar 15 '22 02:03 tbhaxor

yes, I have big sur and it happens to me locally aswell. not sure how to debug && fix

georgettica avatar Mar 23 '22 11:03 georgettica