bash-it-docker icon indicating copy to clipboard operation
bash-it-docker copied to clipboard

[WIP] init(dockerfile): add additional file

Open georgettica opened this issue 4 years ago • 5 comments

related to https://github.com/Bash-it/bash-it/pull/1753

currently fails on https://github.com/pypa/virtualenv/issues/1907 if I understand correctly

to test run 'docker built -t test -f pre-commit.Dockerfile .' and see the error

georgettica avatar Dec 30 '20 08:12 georgettica

@ellerbrock are you still maintaining this repo? If so can you help me solve this issue?

georgettica avatar Jan 04 '21 22:01 georgettica

I'll fix these issues and I am glad you reviewed it :)

Thanks

georgettica avatar Mar 05 '21 06:03 georgettica

it is 1Gi, if we still want to keep it I am all for it :)

you can review again @NoahGorny

georgettica avatar Mar 07 '21 10:03 georgettica

it is 1Gi, if we still want to keep it I am all for it :)

you can review again @NoahGorny

Good job @georgettica ! I would like to have some docs about this dockerfile- we also need to make sure we know how to build it and publish it! Please add some docs on how to build the docker as well

NoahGorny avatar Mar 07 '21 21:03 NoahGorny

Hi @ellerbrock can you please take a look at this? if you do not have the time- can you give me write permissions instead? I also maintain bash-it at the moment

NoahGorny avatar Aug 03 '21 21:08 NoahGorny