flutter_cached_network_image icon indicating copy to clipboard operation
flutter_cached_network_image copied to clipboard
verified publisher icon Baseflow

Support null value for imageUrl

Open BeMacized opened this issue 5 years ago • 5 comments

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

It allows imageUrl to be set to null.

:arrow_heading_down: What is the current behavior?

The assertion that checks that imageUrl is not null, fails when providingnull.

:new: What is the new behavior (if this is a feature change)?

Instead of throwing an exception, the placeholder widget is shown.

:boom: Does this PR introduce a breaking change?

No

:memo: Links to relevant issues/docs

Solves #314

BeMacized avatar Mar 06 '20 15:03 BeMacized

Any chance to merge it?

fryette avatar Apr 23 '20 09:04 fryette

This would be great. Currently I have to check for null.

DFelten avatar Jul 02 '20 11:07 DFelten

Please merge this. I have to put null check :(

SAGARSURI avatar Jul 23 '20 06:07 SAGARSURI

With provider, this would be super useful. At the moment, I have two different loading because of this. I would rather have only one.

@renefloor : Could you tell us what's blocking it ?

bounty1342 avatar Oct 01 '20 01:10 bounty1342

@renefloor Is there a reason this wasn't merged?

smkhalsa avatar Dec 15 '20 13:12 smkhalsa

Closing this PR as it's too out of date by now. If someone still wants this functionality, feel free to open a new PR.

BeMacized avatar Mar 11 '24 10:03 BeMacized