flutter-permission-handler icon indicating copy to clipboard operation
flutter-permission-handler copied to clipboard

Updated Dart SDK version

Open Ric17101 opened this issue 1 year ago • 1 comments

  • update sdk to 2.17.0 to support latest flutter versions such as 3.x

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

:arrow_heading_down: What is the current behavior?

:new: What is the new behavior (if this is a feature change)?

:boom: Does this PR introduce a breaking change?

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

  • [x] I made sure all projects build.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • [ ] I updated CHANGELOG.md to add a description of the change.
  • [x] I followed the style guide lines (code style guide).
  • [ ] I updated the relevant documentation.
  • [x] I rebased onto current master.

Ric17101 avatar Aug 10 '22 06:08 Ric17101

Codecov Report

Merging #887 (66825a2) into master (051828f) will decrease coverage by 11.21%. The diff coverage is n/a.

@@             Coverage Diff              @@
##            master     #887       +/-   ##
============================================
- Coverage   100.00%   88.78%   -11.22%     
============================================
  Files            1        7        +6     
  Lines           16      107       +91     
============================================
+ Hits            16       95       +79     
- Misses           0       12       +12     
Impacted Files Coverage Δ
..._interface/lib/src/method_channel/utils/codec.dart 100.00% <0.00%> (ø)
...lib/src/permission_handler_platform_interface.dart 100.00% <0.00%> (ø)
...hod_channel/method_channel_permission_handler.dart 100.00% <0.00%> (ø)
..._platform_interface/lib/src/permission_status.dart 68.18% <0.00%> (ø)
...andler_platform_interface/lib/src/permissions.dart 91.66% <0.00%> (ø)
...ler_platform_interface/lib/src/service_status.dart 73.33% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 10 '22 06:08 codecov[bot]

Apologies for the belated review. However I am wondering why this is necessary, the current constraints allow the use of any Dart version between 2.15.0 and 3.0.0. Meaning the plugin should work fine with later Flutter versions that require Dart 2.17.0 or higher.

Will close this PR for now, if there are any specific reasons please let me know.

mvanbeusekom avatar Jun 07 '23 10:06 mvanbeusekom