flutter-permission-handler icon indicating copy to clipboard operation
flutter-permission-handler copied to clipboard

`permission_handler` android 13 example notification fix

Open dius00 opened this issue 1 year ago • 1 comments

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...) Bug Fix in the example project, for the main package and android. Solves the following issue https://github.com/Baseflow/flutter-permission-handler/issues/865 for permission_handler

⤵️ What is the current behavior? Permission for notification are not requested on devices running Android 13 when running the example project in

permission_handler

🆕 What is the new behavior (if this is a feature change)? Permission for notification is requested as expected

💥 Does this PR introduce a breaking change? No.

🐛 Recommendations for testing Run the example project and verify that notification permission is requested on emulator/device running SDK 33

📝 Links to relevant issues/docs https://github.com/Baseflow/flutter-permission-handler/issues/865

🤔 Checklist before submitting

  • [X] I made sure all projects build. - Will build when the changes in permission_handler_android are released
  • [X] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • [X] I updated CHANGELOG.md to add a description of the change.
  • [X] I followed the style guide lines (code style guide).
  • [X] I updated the relevant documentation.
  • [X] I rebased onto current master.

dius00 avatar Jul 28 '22 15:07 dius00

Codecov Report

Patch and project coverage have no change.

Comparison is base (cbb3e1e) 100.00% compared to head (59c455a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #881   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           16        16           
=========================================
  Hits            16        16           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 28 '22 15:07 codecov[bot]