flutter-permission-handler icon indicating copy to clipboard operation
flutter-permission-handler copied to clipboard

`Permission.notification` `request()` method not working on Android 13 example project.

Open dius00 opened this issue 1 year ago • 3 comments

🐛 Bug Report

Calling request() method on Permission.notification does not show system dialog and always returns PermissionStatus.denied on Android 13 (Emulator running API: 33 with ABI: arm64-v8a system image).

Expected behavior

Notification permission is requested.

Reproduction steps

Create Android Emulator with API 33, launch the example project, and request notification permission.

Configuration

Version: 10.0.0

Platform:

  • [ ] :iphone: iOS
  • [X] :robot: Android

dius00 avatar Jul 06 '22 18:07 dius00

Turns out the issue is due to the mission permissions in the AndroidManifest, I opened a PR to fix the issue.

dius00 avatar Jul 08 '22 15:07 dius00

Hi @dius00, thank you for bringing this to our attention, and for your PR, it looks good!

I saw however not all the checks succeeded, is it possible that you split your PR into two different PR's? One being the permission_handler_android side, and the other one being the permission_handler? Just like I did with PR #563 and PR #564?

Thanks again for your contribution!

JDDV avatar Jul 28 '22 13:07 JDDV

@JDDV Thanks for the reply! I split the PR in 2 as requested.

The only step left would be a 3rd PR after the PR involvingpermission_handler_android is merged, and the updated package is published to update the dependency in the main permission_handler package, as that is what was breaking the checks earlier (I had bumped both in the PR, and it couldn't find the 10.0.1 for permission_handler_android.

Thanks again, let me know if I need to make any more changes.

dius00 avatar Jul 28 '22 15:07 dius00

Closing this issue, as it seems to be fixed in #880 and #881.

JeroenWeener avatar Jun 29 '23 10:06 JeroenWeener