flutter-permission-handler icon indicating copy to clipboard operation
flutter-permission-handler copied to clipboard

core(windows): remove code that caused location to be always accessed

Open MSOB7YY opened this issue 8 months ago • 2 comments

while a windows version of the app is running, windows will show that the app is always accessing location, even tho location was never accessed or requested from the app code

im not sure why this block was added in the first place even tho the callback doesn't call any other code, i haven't done much tests but await Permission.location.request() returns PermissionStatus.granted normally

PermissionHandlerWindowsPlugin::PermissionHandlerWindowsPlugin(){
--  m_positionChangedRevoker = geolocator.PositionChanged(winrt::auto_revoke,
--    [this](Geolocator const& geolocator, PositionChangedEventArgs e)
--    {
--    });
}

List at least one fixed issue.

  • windows no longer shows that the app is using location
  • closes #1394

Pre-launch Checklist

  • [x] I made sure the project builds.
  • [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • [ ] I updated CHANGELOG.md to add a description of the change.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [x] I rebased onto main.
  • [ ] I added new tests to check the change I am making, or this PR does not need tests.
  • [ ] I made sure all existing and new tests are passing.
  • [x] I ran dart format . and committed any changes.
  • [x] I ran flutter analyze and fixed any errors.

MSOB7YY avatar May 01 '25 00:05 MSOB7YY

Oh yes, came to report this! I was scared when my users reported it!

saif-ellafi avatar Jun 08 '25 21:06 saif-ellafi

What's the reason preventing this PR from getting merged?

LucasXu0 avatar Jul 08 '25 02:07 LucasXu0