flutter-permission-handler icon indicating copy to clipboard operation
flutter-permission-handler copied to clipboard

Handle contacts limited permission

Open Hari-07 opened this issue 1 year ago • 3 comments

The package wasn't currently handling the new CNAuthorizationStatusLimited introduce in ios18. Older versions of ios will remain unchanged. Here's a screen recording showcasing the change

  • ios 17.2

https://github.com/user-attachments/assets/4ec5422a-cd72-4c14-bf5e-3a7227148e38

  • ios 18.0

https://github.com/user-attachments/assets/2a6c5c56-dc16-41b9-977e-1167462d8d7a

List at least one fixed issue.

  • https://github.com/Baseflow/flutter-permission-handler/issues/1387
  • https://github.com/Baseflow/flutter-permission-handler/issues/1376

Pre-launch Checklist

  • [x] I made sure the project builds.
  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • [x] I updated CHANGELOG.md to add a description of the change.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I rebased onto main.
  • [x] I added new tests to check the change I am making, or this PR does not need tests.
  • [x] I made sure all existing and new tests are passing.
  • [x] I ran dart format . and committed any changes.
  • [x] I ran flutter analyze and fixed any errors.

Hari-07 avatar Oct 10 '24 10:10 Hari-07

The check failure of invoking prints seems to be from an old commit, not from my changes. Happy to remove them if required though

Hari-07 avatar Oct 10 '24 10:10 Hari-07

Any update on when this would be merged? This looks good to me!

kvenn avatar Oct 14 '24 15:10 kvenn

Any update on this? I have same issue with iOS 18

levyanjos avatar Oct 19 '24 15:10 levyanjos

Is there any update on this? As we have a client request for this feature.

HappyMakadiyaS avatar Nov 12 '24 08:11 HappyMakadiyaS

Any update ? Apple is deploying the 18.1 right now, I see customers with this issue

starshipcoder avatar Nov 29 '24 13:11 starshipcoder

for those who want it before merging

dependency_overrides:
  # limited access on iOS 18 for contacts
  permission_handler_apple:
    git:
      url: https://github.com/sodality-tech/flutter-permission-handler.git
      ref: main
      path: permission_handler_apple

amrgetment avatar Dec 19 '24 20:12 amrgetment

What about Android 14? it is directly show granted status

inamhusain avatar Dec 20 '24 10:12 inamhusain

What about Android 14? it is directly show granted status

Better to file a separate issue. This PR doesnt touch android

Hari-07 avatar Dec 20 '24 11:12 Hari-07

Hi @Hari-07 can this be merged this week? or can anyone share an update? iOS 18 has been out for 4 months now and this is causing issues for all users on that version

s-alkami avatar Jan 29 '25 20:01 s-alkami

@s-alkami I'd love to, but Im not a maintainer of this package so I dont have the access necessary. If you want you can use our fork like mentioned above, we have been using it for a while with no issues

dependency_overrides: permission_handler_apple: git: url: https://github.com/sodality-tech/flutter-permission-handler.git ref: main path: permission_handler_apple

If the team wants me to make any changes before it can be merged I'd be open to it

Hari-07 avatar Jan 30 '25 03:01 Hari-07

@s-alkami I'd love to, but Im not a maintainer of this package so I dont have the access necessary. If you want you can use our fork like mentioned above, we have been using it for a while with no issues

dependency_overrides: permission_handler_apple: git: url: https://github.com/sodality-tech/flutter-permission-handler.git ref: main path: permission_handler_apple

If the team wants me to make any changes before it can be merged I'd be open to it

noted, thanks @mvanbeusekom - are there any maintainers who can review/merge this change to handle iOS 18 functionality? cc @TimHoogstrate @BeMacized @martijn00 @jurijjzz

s-alkami avatar Jan 30 '25 19:01 s-alkami

please do merge ASAP, it's been 4 months @mvanbeusekom

husainazkas avatar Feb 20 '25 08:02 husainazkas