flutter-permission-handler icon indicating copy to clipboard operation
flutter-permission-handler copied to clipboard

Fixed crashing on machines with early windows 10 version

Open krll-kov opened this issue 1 year ago • 2 comments

Fixed following issue: https://github.com/Baseflow/flutter-permission-handler/issues/1388

Pre-launch Checklist

  • [+] I made sure the project builds.
  • [+] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [+] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is does not need version changes.
  • [+] I updated CHANGELOG.md to add a description of the change.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I rebased onto main.
  • [ ] I added new tests to check the change I am making, or this PR does not need tests.
  • [ ] I made sure all existing and new tests are passing.
  • [ ] I ran dart format . and committed any changes.
  • [ ] I ran flutter analyze and fixed any errors.

krll-kov avatar Sep 27 '24 17:09 krll-kov

@mvanbeusekom can you review it please?

krll-kov avatar Nov 11 '24 23:11 krll-kov

@mvanbeusekom this actually fixes 2 more problems now from here (with total of 3):

https://github.com/Baseflow/flutter-permission-handler/issues/1394

m_positionChangedRevoker was defined but never actually used in the package, it only caused constant geo-location usage as soon as app is started, without even using any of the features of this package. It caused network lags, crashes and other staff, so fix is really helpful

krll-kov avatar Nov 06 '25 16:11 krll-kov