Adds MacOS Support
This PR replaces this one for macOS platform support.
- #337
Pre-launch Checklist
- [x] I made sure the project builds.
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes. - [x] I updated
CHANGELOG.mdto add a description of the change. - [x] I updated/added relevant documentation (doc comments with
///). - [x] I rebased onto
main. - [x] I added new tests to check the change I am making, or this PR does not need tests.
- [x] I made sure all existing and new tests are passing.
- [x] I ran
dart format .and committed any changes. - [x] I ran
flutter analyzeand fixed any errors.
This PR is fixes for comments of: https://github.com/Baseflow/flutter-permission-handler/pull/946
@mvanbeusekom is there anything I can do to help move this forward? @alex-melnyk I think the pipeline is now broken because of some deprecated material fields in the example app
Yes, please help me fix the pipeline
@alex-melnyk I think I cant directly contribute here, but I fixed the warnings over at https://github.com/alex-melnyk/flutter-permission-handler/pull/1
@alex-melnyk I think I cant directly contribute here, but I fixed the warnings over at alex-melnyk#1
@mvanbeusekom Are we waiting for anything else here? Seems like https://github.com/alex-melnyk/flutter-permission-handler/pull/1 has fixed all warnings ✅ Could you please review it?
In the meantime, is there a way I could temporarily use https://github.com/alex-melnyk/flutter-permission-handler/pull/1 in my current project?
Writing the following in pubspec.yaml doesn't work ❌
permission_handler:
git: https://github.com/dkbast/flutter-permission-handler.git
I believe you need to either add ref: main or remove the .git in the url
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
78a549c) 71.42% compared to head (a6ef4a5) 71.42%.
Additional details and impacted files
@@ Coverage Diff @@
## main #1207 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 1 1
Lines 35 35
=======================================
Hits 25 25
Misses 10 10
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 71.42% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@alex-melnyk I think I cant directly contribute here, but I fixed the warnings over at alex-melnyk#1
@mvanbeusekom Are we waiting for anything else here? Seems like alex-melnyk#1 has fixed all warnings ✅ Could you please review it?
In the meantime, is there a way I could temporarily use alex-melnyk#1 in my current project?
Writing the following in
pubspec.yamldoesn't work ❌permission_handler: git: https://github.com/dkbast/flutter-permission-handler.git
You need to override dependencies to use your implementation, here is example:
dependency_overrides:
# https://github.com/Baseflow/flutter-permission-handler/pull/1207
permission_handler:
git:
url: [email protected]:alex-melnyk/flutter-permission-handler.git
path: permission_handler
ref: master
# https://github.com/Baseflow/flutter-permission-handler/pull/1207
permission_handler_apple:
git:
url: [email protected]:alex-melnyk/flutter-permission-handler.git
path: permission_handler_apple
ref: master
@alex-melnyk I think I cant directly contribute here, but I fixed the warnings over at alex-melnyk#1
Thank you for the support!
@mvanbeusekom bumping this up, as this PR would really help fixing a hole in the ecosystem, in terms of compatibility.
hi @alex-melnyk what do you think about permission CGPreflightScreenCaptureAccess and request CGRequestScreenCaptureAccess on macos? i search reference about this on flutter but still not found, so i use MethodChannel to request that
@mvanbeusekom Hello, could you please review this PR ? It's a really important features. Thanks :)
Please, push it.
@mvanbeusekom up please