XamarinMediaManager icon indicating copy to clipboard operation
XamarinMediaManager copied to clipboard

Enabled setting auto exit full screen when playback completes on iOS …

Open jamsoft opened this issue 3 years ago • 1 comments

…cannot find equal functionality on Android in order to implement.

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

When video playback on iOS is in full screen mode and the media item completes, the view is auto switched to normal inline view. Without closing full screen first any navigation will fail to actually navigate

:arrow_heading_down: What is the current behavior?

Full screen prevents navigation

:new: What is the new behavior (if this is a feature change)?

Full screen closes at the end of the media item.

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

Try setting the value in XAML on VideoView and play full screen video with the MediaItemComplete event handler performing a navigation.

:memo: Links to relevant issues/docs

n/a

:thinking: Checklist before submitting

  • [x ] All projects build
  • [ x] Follows style guide lines
  • [ ] Relevant documentation was updated
  • [ ] Rebased onto current develop

jamsoft avatar Jul 14 '21 14:07 jamsoft

Hmm not sure this is a good way to solve this. Can't you add it as a static on the renderer only for iOS? The current code isn't even implemented properly for Forms...

martijn00 avatar Aug 10 '21 12:08 martijn00