LottieXamarin icon indicating copy to clipboard operation
LottieXamarin copied to clipboard

Published 20 hours ago • verified publisher icon Baseflow

Support for .NET 6

Open markuspalme opened this issue 2 years ago • 12 comments

🚀 Feature Requests

The library currently targets Xamarin.iOS but not net6-ios/net6-android. The new TFMs are the future and using this library in new projects is currently not possible.

To address my own very short-term needs I have created a port of the iOS part of this library to .NET 6: https://github.com/markuspalme/LottieNet6/

Platforms affected (mark all that apply)

  • [X] :iphone: iOS
  • [X] :robot: Android
  • [X] :checkered_flag: WPF
  • [ ] :earth_americas: UWP
  • [X] :apple: MacOS
  • [X] :tv: tvOS
  • [X] :monkey: MAUI

markuspalme avatar Sep 13 '22 16:09 markuspalme

+1

FreakyAli avatar Sep 15 '22 11:09 FreakyAli

It is not currently possible to use Lottie on net6-ios due to breaking changes in net6-ios: "All code must be recompiled to support .NET 6. Existing assemblies (such as NuGets built for the old TargetFrameworkIdentifier xamarinios10) won’t work and won’t be supported. Non-xamarin specific assets for net4.x, netstandard, netcoreapp, net5.0+, etc. will work fine however." - Link Any plans on rebuilding on .NET 6?

evgenyvalavin avatar Oct 05 '22 11:10 evgenyvalavin

@evgenyvalavin I have forked the library and ported it to net6-ios: https://www.nuget.org/packages/Lottie.iOS

But of course an update of this excellent library would be better than a fork long-term.

markuspalme avatar Oct 05 '22 11:10 markuspalme

@markuspalme thanks! I already use the NuGet package.

Let's hope together this library will be updated 😄

evgenyvalavin avatar Oct 05 '22 12:10 evgenyvalavin

@markuspalme @evgenyvalavin My understanding of this is that this library will be obsolete and won't be updated to .net 6 at all. Instead, there is a Skia Sharp control that is going to be the Future of Lottie Animations in most .Net environments https://mono.github.io/SkiaSharp.Extended/api/ui-maui/sklottieview.html, I mean obviously, that's not on par with BaseFlow's version but that's the best we have ATM.

FreakyAli avatar Oct 06 '22 03:10 FreakyAli

@FreakyAli How can I use sklottieview in xamarin.native apps ? I think this is not possible and we should wait for the update of this package anyway.

Pluxury avatar Oct 10 '22 17:10 Pluxury

@Pluxury You are right for now this seems to be the case

FreakyAli avatar Oct 10 '22 17:10 FreakyAli

Does anyone have an android .net6 port for this?

AdamDiament avatar Oct 26 '22 12:10 AdamDiament

@martijn00 what is the current plan for this?

petro2050 avatar Nov 09 '22 02:11 petro2050

I'm more than happy to accept a PR to fix this and release a new version. I've already done some work but can't get iOS to work.

martijn00 avatar Jan 17 '23 16:01 martijn00

@martijn00 where is the work you already started and do you remember what problems you were having on iOS?

IeuanWalker avatar Apr 26 '23 16:04 IeuanWalker

@martijn00 where is the work you already started and do you remember what problems you were having on iOS?

@IeuanWalker this is the in progress PR. I'm not aware of the specific iOS issues https://github.com/Baseflow/LottieXamarin/pull/379

AdamDiament avatar Jul 26 '23 12:07 AdamDiament