ExoPlayerXamarin icon indicating copy to clipboard operation
ExoPlayerXamarin copied to clipboard
verified publisher icon Baseflow

Media3

Open ArchangelWTF opened this issue 2 years ago • 4 comments

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Introduces Media3 (Fixes: https://github.com/Baseflow/ExoPlayerXamarin/issues/157)

@martijn00 This fully introduces Media3, I've updated the PackageId's as I think it would break to have media3 published on the current ExoPlayer Id's..

As well as that, if you merge this.. Could you set media3 as the main branch for this repository? This will allow us to keep the current develop and exoplayer branches should we need to do anything with them.

:arrow_heading_down: What is the current behavior?

:new: What is the new behavior (if this is a feature change)?

:boom: Does this PR introduce a breaking change?

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

  • [ ] All projects build
  • [ ] Follows style guide lines
  • [ ] Relevant documentation was updated
  • [ ] Rebased onto current develop

ArchangelWTF avatar Sep 04 '23 08:09 ArchangelWTF

@martijn00 When you have time to look this over can you approve and merge this?

ArchangelWTF avatar Oct 03 '23 09:10 ArchangelWTF

Hi! Is there a reason why this has not been integrated and released to the nuget package ?

Mackly avatar Mar 02 '24 07:03 Mackly

@Mackly Because it was decided not to be adopted, also Xamarin will have a Media3 package available soon (Went into review this week: https://github.com/xamarin/AndroidX/issues/710)

ArchangelWTF avatar Mar 05 '24 08:03 ArchangelWTF

Thanks for the reply, I am following closely

Mackly avatar Mar 05 '24 17:03 Mackly