omi icon indicating copy to clipboard operation
omi copied to clipboard

Battery indicator by double tap

Open skywinder opened this issue 11 months ago • 6 comments

1/ added double tap with battery indicator on device

2/ added docs with info about led colors and it's meaning

https://github.com/user-attachments/assets/8b8700fd-a377-41b2-9b13-f8855d5ec8e3

skywinder avatar Apr 04 '25 13:04 skywinder

cool man. please split this PR into 2 parts, one for bug fix and another onr for the new feature.

for the bug fix, please tell me more about the 4096 number. why is this and why we need this ?

@skywinder

beastoin avatar Apr 04 '25 23:04 beastoin

do you mean 4074?

It's s the maximum voltage my Omi gets when it’s fully charged. That corresponds to about 96%, which is what I usually see in the app when it’s fully charged.

The better approach would be to gradually adjust the percentage rather than just cutting off the top value — but that would require more changes. For now, I want to keep it minimal. So the battery indicator in the app will show 100%, then drop to 97% sharply, and from there start decreasing as usual.

skywinder avatar Apr 05 '25 08:04 skywinder

#2154 - @beastoin separated fix here. I will revert it in this PR and rename it to the feature

skywinder avatar Apr 05 '25 09:04 skywinder

0/ ok, replied https://github.com/BasedHardware/omi/pull/2154#issuecomment-2782426832

1/ cool man ~ btw, what is the indicator system are you following for the battery-related indicator ? it looks complicated a bit so i want to understand more about how our users could adapt with this system.

Screenshot 2025-04-07 at 15 24 29

@skywinder

beastoin avatar Apr 07 '25 08:04 beastoin

hey man, it's cleaning time.

/ closed

3 days with no updates feel free to reopen it anytime

beastoin avatar Apr 14 '25 10:04 beastoin

it looks complicated a bit so i want to understand more about how our users could adapt with this system.

So, I’ve tested five different options—different colors, blink counts, and frequencies—and I found this one to be the most straightforward. But I’m totally open to feedback—maybe you have a better idea for how to handle the indication.

The only thing I really want is to be able to check the battery on the OMI without needing my phone nearby. The simplest way is just to blink from 1 to 10 times, maybe with different colors—but counting up to 10 blinks is actually pretty hard in practice, so I decided to simplify it.

I went with a maximum of 3 blinks using different colors to show the battery level. I also wrote a detailed README so it’s clear and easy to understand.

What’s your take on this? Any ideas for how to improve the UX further? @thinhx

skywinder avatar Apr 14 '25 14:04 skywinder

Man, I don’t want to disappoint you, but I don’t think we should add more LED logic to the LED system just to indicate battery level. Honestly, I’m not sure why an always-on device really needs this feature.

So next, please create an issue, reference your implementation in that issue, and seek feedback from the team and the community. I’d be happy to merge it if the team or our community finds the feature valuable.

@skywinder

beastoin avatar Apr 21 '25 09:04 beastoin

Agree. It makes no sense. No one will remember the number of blinks and their relation to battery levels.

smian1 avatar Apr 27 '25 19:04 smian1

/ close

> > 3 days without updates. > please seek feedback from the community/team, then feel free to reopen the ticket.

beastoin avatar Apr 28 '25 13:04 beastoin

Fix #1834

skywinder avatar May 12 '25 16:05 skywinder