omi icon indicating copy to clipboard operation
omi copied to clipboard

Conversations are still memories. Memories are still facts

Open kodjima33 opened this issue 8 months ago • 3 comments

This already became a joke as i've asked this to be fixed 5+ times

In database, conversations are still memories and memories are still facts

EVERYWHERE IT SHOULD BE

  • Conversations = it's what contains transcriptions, summaries, etc...
  • Memories = it's what containts facts about the user and facts that the user has learned.

This might seem as a useless task but it's actually very important as this is the foundation for the future. The sooner we fix it, the better

THERE SHOULD BE NO FACTS. FIX EVERY WORD, EVERYWHERE, EVEN IF IT TAKES FEW DAYS

kodjima33 avatar Mar 30 '25 02:03 kodjima33

We had to keep old memories (which should be conversations) and old facts (which should be memories) routes for backwards compatibility with the existing apps on prod. Removing them will break prod apps. And in database it is still memories (instead of conversations) and facts (instead of memories) because renaming the collections will break the whole db. Data needs to be migrated step by step to avoid breaking the backend.

Stuff that is left for this ticket:

  • Removing old memories and facts routes a week after new version goes to prod
  • Migrate the data in db so as to use new collections (conversations instead of memories and memories instead of facts). This part will take time as the complete data has to be migrated

Past work related to this ticket: https://github.com/BasedHardware/omi/pull/1987 https://github.com/BasedHardware/omi/pull/2016 https://github.com/BasedHardware/omi/pull/2017 https://github.com/BasedHardware/omi/pull/2071

mdmohsin7 avatar Mar 30 '25 07:03 mdmohsin7

I will work on this and let me know once we have new release and good to go for migration

varshith257 avatar Mar 30 '25 17:03 varshith257

duplicated #1973

beastoin avatar Mar 31 '25 11:03 beastoin