addok-docker icon indicating copy to clipboard operation
addok-docker copied to clipboard

Version of etalab/addok not up to date

Open pmiossec opened this issue 10 months ago • 2 comments

The version of etalab/addok seems not up to date.

#39 is one proof that the image is not up to date.

Differences in the answer returned is another clue:

  • From GeoServices (https://data.geopf.fr/geocodage/search?autocomplete=0&index=address&limit=1&returntruegeometry=false&postcode=75014&q=110+Avenue+de+France%2c+75014+Paris)
{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [2.323109, 48.83643]
      },
      "properties": {
        "label": "110 Avenue du Maine 75014 Paris",
        "score": 0.622331961722488,
        "housenumber": "110",
        "id": "75114_5922_00110",
        "name": "110 Avenue du Maine",
        "postcode": "75014",
        "citycode": "75114",
        "x": 650315.36,
        "y": 6859810.46,
        "city": "Paris",
        "district": "Paris 14e Arrondissement",
        "context": "75, Paris, Île-de-France",
        "type": "housenumber",
        "importance": 0.79302,
        "street": "Avenue du Maine",
        "_type": "address"
      }
    }
  ]
}
  • From addok docker (http://localhost:7878/search?autocomplete=0&index=address&limit=1&returntruegeometry=false&postcode=75014&q=110+Avenue+de+France%2c+75014+Paris)
{
  "type": "FeatureCollection",
  "version": "draft",
  "features": [
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [2.323109, 48.83643]
      },
      "properties": {
        "label": "110 Avenue du Maine 75014 Paris",
        "score": 0.622331961722488,
        "housenumber": "110",
        "id": "75114_5922_00110",
        "name": "110 Avenue du Maine",
        "postcode": "75014",
        "citycode": "75114",
        "x": 650315.36,
        "y": 6859810.46,
        "city": "Paris",
        "district": "Paris 14e Arrondissement",
        "context": "75, Paris, Île-de-France",
        "type": "housenumber",
        "importance": 0.79302,
        "street": "Avenue du Maine"
      }
    }
  ],
  "attribution": "BAN",
  "licence": "ETALAB-2.0",
  "query": "110 Avenue de France, 75014 Paris",
  "filters": {
    "postcode": "75014"
  },
  "limit": 1
}

Visual diff:

Image

Especially the "version": "draft" which is not very encouraging...

Can we expect an update of the docker image, please? If this project could get some little love and time, it would be great... At least a clarification on the status of the project will be interesting

Thanks in advance. /cc @jdesboeufs

pmiossec avatar Mar 19 '25 09:03 pmiossec

Hello,

I don't work anymore for BaseAdresseNationale. But version: 'draft' is just related to https://github.com/geocoders/geocodejson-spec which has never been released as a stable version. data.geopf.fr just strip this information.

Currently if you want an updated version of addok-server I suggest you to use https://github.com/livingdata-co/addok-server which is maintained by my company. We can publish updated docker image if needed.

jdesboeufs avatar Mar 19 '25 10:03 jdesboeufs

@jdesboeufs Thanks for the heads up.

But version: 'draft' is just related to https://github.com/geocoders/geocodejson-spec which has never been released as a stable version. data.geopf.fr just strip this information.

Good to know.

Currently if you want an updated version of addok-server I suggest you to use https://github.com/livingdata-co/addok-server which is maintained by my company.

👍

We can publish updated docker image if needed.

That will be greatly appreciated because you are the best placed to know when to release new images.

I have fixed a small issue in docker-compose.yml ( https://github.com/livingdata-co/addok-server/pull/11 ) but I think I found an issue with the last version ( https://github.com/livingdata-co/addok-server/issues/12 ). I propose to continue the discussion there...

pmiossec avatar Mar 21 '25 12:03 pmiossec