BasLee

Results 13 comments of BasLee

@tmazor @alisman @inodb Removing the checkbox for the heatmap wouldn't be too hard. However swapping the longer labels from the X-axis to the Y-axis might be some work: if I...

Updates after community call 2022-04-20. To clarify the function of the button the following changes were made: - Move the button to the 'add tracks' menu - Rename the 'add...

> 1. Is it ok that we lose clinical track url state for logged out users because we no longer update url > 2. Same question for groups. Why are...

Added userSettingsJson query param after hash to prevent it from being passed to the server in [14e17c4](https://github.com/cBioPortal/cbioportal-frontend/compare/d44a497fd7eb858dfe038ae4f6050daad90b67d9..14e17c442e688d27d929199da665656825444c33)

> @BasLee did some manual testing of the feature. Seems good but for a couple things: > [..] @alisman, @pvannierop : all these things were solved in [889494c](https://github.com/cBioPortal/cbioportal-frontend/pull/4305/commits/889494c510627e95bcd65f7143df6db6191a7997), [231e9ed](https://github.com/cBioPortal/cbioportal-frontend/pull/4305/commits/231e9ed83239096ca3443589c6f24a4bd502c5ad) and...

@inodb and @tmazor Thank you for reviewing! I think we already addressed the horizontal bar issue: will look into it. The search bar now shows a filter name and value,...

> @BasLee one more question: is there a use case to be able to select both hg19 + hg38? If not it might be cleaner to just list in the...

> One more bug I found: @inodb: fixed in 9db3773

> Looks like there's still an issue vs production for queries not part of example queries [..] @inodb a bit late, reading this just now... But yes, lets discuss what...

> There is one more suggestion about this pull request, since this pr introduces a new data format, we should also add a new method to validate this new data...