cwl-airflow icon indicating copy to clipboard operation
cwl-airflow copied to clipboard

Use of Conditional workflows

Open francescobianco opened this issue 3 years ago • 2 comments

With our team we are starting to use the Conditional Workflows, as descrived here https://www.commonwl.org/user_guide/24_conditional-workflow/index.html but, it works with v1.2 of CWL actually shipped into https://pypi.org/project/cwltool/3.1.20210521105815/

For your constraint reason we can't do this

pip install cwltool==3.1.20210521105815

We would like a new release from you that includes this version as a constraint 3.1.20210521105815

instead of https://github.com/Barski-lab/cwl-airflow/blob/8aa26f6a50a8ea15bb8d544225f2dfe09668a5f3/setup.py#L99

Do you have a time schedule to which we can refer, when will it be possible to have this version?

Thanks to: @mruffalo @mr-c @shubham-padia @portah @michael-kotliar @matteo-opencrmitalia

P.S. I apologize for my bad exposure in English

francescobianco avatar Jun 07 '21 09:06 francescobianco

Hi @francescobianco

Thank you for submitting an issue. We can't use the latest version of cwltool due to this bug https://github.com/common-workflow-language/cwltool/issues/1349. In order to make CWL-Airflow use the latest cwltool, first, I will need to fix that bug in cwltool:) I will work on it at the nearest time.

Meanwhile, as this bug relates only to a certain type of workflows, you can try to use the latest cwltool version by either changing it directly in setup.py or just manually updating it with pip3 install -U cwltool.

Let me know if you have any issues with conditional support in CWL-Airflow. It's still a work in progress, so I will be happy to see if there any bug fixes or additional features required.

michael-kotliar avatar Jun 07 '21 16:06 michael-kotliar

Quick note for myself regarding a confirmed bug in cwltool

For cwltool==3.1.20210628163208 it still fails with the same error, however, if in the tool I put docker in the requirements section instead of hints, it works fine.

michael-kotliar avatar Jun 29 '21 15:06 michael-kotliar