SATPI icon indicating copy to clipboard operation
SATPI copied to clipboard

DESCRIBE should follow Transformed response

Open Barracuda09 opened this issue 5 years ago • 2 comments

Hi @Barracuda09 ,

Another issue detected with the ChildPIPE frontend: The RTCP packets are not confirmant. See the content (from the LOG) when using it with the real frontend disabled and the "transformation" and "advertise" enabled for the virtual frontend:

v=0
o=- 0253037672 0253037672 IN IP4 192.168.1.27
s=SatIPServer:1 0,0,0
t=0 0
m=video 0 RTP/AVP 33
c=IN IP4 0.0.0.0
a=control:stream=3
a=fmtp:33 ver=1.5;tuner=4,240,1,15;exec=None
a=sendonly

So, when using the TRANSFORMATION functionality the a=fmtp:33 ... line requires to be conformant with the selected ADVERSITE mode. If not then some clients refuse to play.

Regards.

Originally posted by @lars18th in https://github.com/Barracuda09/SATPI/issues/69#issuecomment-550260961

Barracuda09 avatar Nov 08 '19 08:11 Barracuda09

However, I think this issue requires low priority. Not all SAT>IP clients parse the full a=fmtp:33 line.

lars18th avatar Nov 11 '19 17:11 lars18th

However, I think this issue requires low priority. Not all SAT>IP clients parse the full a=fmtp:33 line.

I've discovered some clients that parse this line. They use it for checking if the requested frequency are tuned when changing the transponder. So, it's required to provide a correct output for these clients.

lars18th avatar Mar 13 '21 17:03 lars18th

Should be fixed with 7107fa566541e6c443887188c8c4793dac38a4ef

Barracuda09 avatar Nov 12 '22 12:11 Barracuda09

Should be fixed with 7107fa5

Yes. So thank you. Only try to fix the current empty pid list bug: a=fmtp:33 ver=1.0;src=1;tuner=4,240,1,15,11953.5000,h,dvbs,qpsk,off,27500,34;pids= (described in https://github.com/Barracuda09/SATPI/issues/169#issuecomment-1312714160)

So if you want you can close this issue.

lars18th avatar Nov 13 '22 12:11 lars18th

Close as requested

Barracuda09 avatar Nov 13 '22 12:11 Barracuda09