Barion

Results 17 comments of Barion

> As another comment, it looks probably 10x cleaner if you make a local variable for `event.includeServer()` and `event.includeClient()` just left that as it was, I'll change it

> As one comment, the "complicated" datagen that is simplified by the helpers only really applies to vanilla or Forge datagen, I've got quite a few custom data generators that...

I could make addProvider return the added provider. this would allow you to do this ```java var example = event.addProvider(include, ExampleProvider::new); event.addProvider(include, (...) -> new OtherProvider(..., example, ...); ```

> I could make addProvider return the added provider. this would allow you to do this > > ```java > var example = event.addProvider(include, ExampleProvider::new); > event.addProvider(include, (...) -> new...

As @KnightMiner pointed out there are scenarios where data providers depend on other providers to run (e.g. item tag provider). I'm not sure how this would be possible with your...

> While true it does not supply an OOTB solution for chaining additional generators (nor custom generators), the fact that it is an extensible object means modders can add those...

@Shadows-of-Fire I just had an idea on how to add registry providers to this pr. What do you think? ```java event.registries(builder -> builder .add(Registries.ENCHANTMENT, ApothEnchantmentProvider::bootstrap) .add(..., ...) ); ```

@KnightMiner Should I add the above mentioned method for registry providers before merging? Should I add this to the docs? (I can't merge despite you approved the pr?)

same for CurseForge