obs-websocket-dotnet icon indicating copy to clipboard operation
obs-websocket-dotnet copied to clipboard

[ISSUE] `SetVideoSettings()` API isn't currently usable

Open DrEsteban opened this issue 3 months ago • 0 comments

Issue Type

  • Bug
  • Feature Request (It's kinda both... A "design" bug)

Describe the issue Right now the SetVideoSettings() API is basically unusable. That's because all the setters on the OBSVideoSettings object model are marked as internal - therefore it cannot be edited or even constructed to make changes to it.

I've confirmed that the API works as expected, though, if you simply make the setters public to allow edits. (Another option would be to mark them as init and provide a constructor to allow customizing them.)

In other places where internal setters are used, the API takes that into account by exposing "deconstructed" APIs. (E.g. InputVolume has SetInputVolume(string, float, bool).) But not with SetVideoSettings() - as currently written it's not usable without using JSON or Reflection haxx.

To Reproduce Try to call the SetVideoSettings() API in any meaningful way, and realize you can't 🙂

Expected behavior The SetVideoSettings() API, being an exposed API in the library, is actually usable.

Screenshots N/A

Versions Latest, as of 5/21/2024

Additional context N/A

DrEsteban avatar May 21 '24 16:05 DrEsteban