BannerlordCoop icon indicating copy to clipboard operation
BannerlordCoop copied to clipboard

Setup CI for project

Open garrettluskey opened this issue 4 years ago • 5 comments

We want to verify that the project builds and all tests pass before a merge request is accepted

garrettluskey avatar Aug 04 '20 21:08 garrettluskey

@araex want to look into this?

garrettluskey avatar Aug 06 '20 22:08 garrettluskey

Any idea what tool you want to use for this? (I've heard AppVeyor is used for a lot of CI/CD targeting Windows.. Though I'm not sure why aside from maybe just better than usual support for Windows native stuff.)

Moggers avatar Aug 26 '20 04:08 Moggers

Github actions would be best for now. Eventually, we will have to setup a local custom runner due to Bannerlord licensing. For now, we can set up actions for dotnet compiling and running xunit tests.

garrettluskey avatar Aug 26 '20 18:08 garrettluskey

I was made aware that the guys over at BUTR are generating reference assemblies automatically for bannerlord and are making them available through a nuget feed.

An example of a user of that feed can be found here. Credentials are apparently necessary because github does not allow anonymous access, we can create use some dummy user for that. The credentials need to be xml encoded.

Thanks to Aragas from the BUTR team the suggestions.

araex avatar Jan 30 '21 11:01 araex

I agree with this idea, I think in order to get around the building aspect of the project (especially on custom runners), we should supply the reference assemblies of our module through a Nuget Feed which can be taken in, then we pull in and build that with the existing API provided, this may be the way we get around it, however a Custom Runner is going to need a legal set of M&B2 files, is there any documentation regarding that?

jordonfirth avatar Apr 10 '21 20:04 jordonfirth