Cinder-Asio icon indicating copy to clipboard operation
Cinder-Asio copied to clipboard

ci::Buffer moving to a regular container

Open richardeakin opened this issue 9 years ago • 2 comments

Hey, after doing a quick survey I noticed that there are some places where ci::Buffers are being passed by value (like in the various onRead() methods). Where this was almost free before, it will now cause the Buffer to be copied, so once this goes through you'll probably want to either update those to be BufferRefs or pass by const&.

richardeakin avatar May 05 '15 02:05 richardeakin

Looks like this might be the only issue preventing Cinder-Asio to be used on the current master branch.

pizthewiz avatar Jun 09 '15 17:06 pizthewiz

This seems to be all sorted in ec8ce36.

pizthewiz avatar Jun 30 '15 18:06 pizthewiz