Bauke Scholtz comments

Repositories
Issues
Comments

Results 273 comments of


                                            Bauke Scholtz

Backport of CSP-related changes

LGTM :) But why exactly is Issue5576IT disabled? Have you already ran the entire 4.0 TCK on this branch? Did it all pass? (sorry for late response, I was vacationing)

<sl-dialog> await hide() doesn't work in testing environment

While creating a reproducer I figured out the await hide() before show actually works fine. Excuses! The second issue still remains though. The await hide() never resolves in a testing...

<sl-dialog> await hide() doesn't work in testing environment

The keyword is "testing environment". E.g. WTR/Mocha/Chai.