Bauke Scholtz
Bauke Scholtz
PR created to exclude test: https://github.com/jakartaee/faces/pull/1961 Issue created to remind us of formalizing it for 5.0: https://github.com/jakartaee/faces/issues/1962
Agreed. The OmniFaces `ResetInputAjaxActionListener` also does this. The impl should boil down to this ```java public void resetValues(FacesContext facesContext, java.util.Collection clientIds) { VisitContext visitContext = VisitContext.createVisitContext(facesContext, clientIds, null); this.visitTree(visitContext, new...
Clarifying spec can only be done in next version (which is currently 5.0). But fixing impl can be done in any version.
Yeah, backporting the fix to 4.0 impl is OK.
> @BalusC the VDL doc for `f:resetValues` specifically calls out that it does not walk children. Its odd that it was designed this way? > > https://docs.oracle.com/javaee/7/javaserver-faces-2-2/vdldocs-facelets/f/resetValues.html > > >...
This was the original discussion and I'm not seeing any incentive for that restriction: https://github.com/jakartaee/faces/issues/1060. After years of using OmniFaces ResetInputAjaxActionListener and PrimeFaces resetValues which actually do that I've never...
Related: https://github.com/eclipse-ee4j/mojarra/issues/5404
1. Level is fixed, it indeed caused duplicate logs (as the container by default indeed already deals with it). 2. Rethrow is correct as it is, so nothing changed there.
> Is this a dynamic component property or a dynamic application property? Application scoped (it's a static method returning the value of a context param with a fallback to a...
Yeah I remember a similar case with a postcode/address autocomplete JS library. I just forked and rewrote it to allow specifying client IDs as option rather than adhering to predefined...