roadrunner-bundle icon indicating copy to clipboard operation
roadrunner-bundle copied to clipboard

Move vendor/bin/rr get --location bin/ into symfony recipe

Open barell opened this issue 5 years ago • 2 comments

Hi, thanks for creating this bundle!

I wonder if we could move this step: vendor/bin/rr get --location bin/

into symfony flex recipe?

Or is there any reason not to do that?

My use case is that I run composer install on build environment and it would be nice if I don't need to do more manual steps. Otherwise I will need to create some script to check if the rr binary exists, and execute this step if not.

barell avatar Aug 19 '20 14:08 barell

Hi! Thanks for using this bundle :)

This is actually a great idea as vendor/bin/rr get will download the binary only if it's missing!

I will add to the flex recipe an auto-script, so this will be executed on every composer install and update.

I plan to release 1.3 soon and it will require a flex recipe update, I will apply your suggestion to the recipe PR.

While waiting for that you can manually add "rr get --location %BIN_DIR%": "script" to your auto-scripts section in composer.json

Baldinof avatar Aug 19 '20 16:08 Baldinof

Thank you! Just tested it, works great :+1:

barell avatar Aug 19 '20 21:08 barell