Magnus Hauge Bakke
Magnus Hauge Bakke
@tpetry @staudenmeir I suggest reverting to `joinLateral` and `leftJoinLateral`, to keep the methods separate from the `laravel-postgresql-enhanced` package. That way, users can decide to switch from the package methods to...
> Renaming to not break my package would be nice 👍 > > But I still don't get the `$type = 'inner'` param of the query. Is that to supply...
> @Bakke I had another idea for the `$lateral` parameter: A `LateralJoinClause` subclass of `JoinClause` IMO, that's a better solution and "more OOP". The class would be empty, but `compileJoins()`...
@staudenmeir I rewrote the code to use a `JoinLateralClause` class instead now. @dkulyk I left this change as a separate commit. As a reviewer I thought you could decide if...
> Thanks. Can you please add integration tests? The queries should be tested against actual databases. Should I create separate `LateralJoinTest.php` for MySQL, Postgres and SQL server under `tests/Integration/Database`?
@staudenmeir I added some simple integration tests now. They are skipped for MySQL < 8.0.14 and MariaDB.
@staudenmeir Great, thanks! Marking it as ready for review so @taylorotwell can look over it as well.
@staudenmeir I made a small change to the integration tests. `limit` is changed to `2` and `assertCount` is used to check the number of returned rows. I think it makes...