Results 18 comments of BakaFT

https://github.com/rumi-chan/Sakura/releases/tag/v1.0 Read release changelogs carefully. > Known bugs >- Crash game when choose Default option >- Some skins of little legends lead to game crash (River Sprite, Socialite Nixie,..) >-...

I don't see any substantial benefits from this commit. > Currently preloading starts too early, no document exists yet What‘s the benefit of delaying it? Or rather, what are the...

>the perfect scenario is allow user symlink plugins folder into node_modules and use npm/yarn/pnpm/etc to manage installed plugins You are assuming all users are devs when some users don't even...

**换肤**二字十分宽泛,但实际情况是即使是**换色**也需要一套设计合理的颜色搭配,并且需要考虑到有的组件可能使用硬编码值,适配工作不会有那么轻松,如果有兴趣做出贡献,参考https://www.naiveui.com/zh-CN/light/docs/customize-theme 换字体这事情相比之下简单得多

1>需要考虑的边界条件太多。用户的分辨率,用户设置的客户端分辨率,多屏,系统DPI缩放之类因素考虑起来麻烦得很 2>可能存在于其他东西的冲突,比如WeGame,或者PenguLoader,导致错位或显示异常 3>虽然开关可以解决2的问题,但是我只是想说这个可有可无的功能做出来的付出大于回报,我猜maintainer不会优先考虑,或者不会考虑这个功能

1> All RCs installed is listed in `%PRGRAMDATA%\Riot Games\RiotClientInstalls.json` 's `associated_client` object ```json { "associated_client": { "d:/wegameapps/英雄联盟/riot client/../LeagueClient/": "d:/wegameapps/英雄联盟/riot client/riotclientservices.exe" }, "patchlines": { "KeystoneFoundationTencentLeagueLivePublicWin": "d:/wegameapps/英雄联盟/riot client/riotclientservices.exe" }, "rc_default": "d:/wegameapps/英雄联盟/riot client/riotclientservices.exe"...

All other code parts looks good to me. But 1> You should try to beautify your commit message referring to previous commits 2> `61365e9` and `3787488` should be squashed into...

This error usually occurs when `icudtl.dat` is missing. Did you copied **only** the main executable elsewhere like desktop? If so, you should create a **shortcut** instead.