openmrs-module-bahmniapps
openmrs-module-bahmniapps copied to clipboard
BAH-3052 | Refactor. search using extraIdentiervalues and display configured identifier in patientList
@SanoferSameera I think there is a bigger question here
- you are now returning more fields: extraIdentifierVal and extraIdentifiers. Before we were only returning "uuid, name, identifier, activeVisitUuid, hasBeenAdmitted" fields.
- The additional fields are not documented. This actually is an enhancement to our "patient lists". This is not an one-off, we must document the usage of the fields and let implementers know that beyond primary identifier, other identifiers are also searchable in the patient lists from now on.
- "extraIdentifiers" is basically list of "identifier type name". I am not sure thats required - it can be simple textual search. We don't have to match identifier type name. Do we? If thats the case, then just return another field "additionalIdentifiers" (better than extraIdentifiers?)
- we need to document that bahmni patient list queries can now also "additionalIdentifiers" in the custom query that they write.
- have we tested the same query on say "bahmni demo"? whether ommitting the extra fields would throw any error? we have to be backward compatible?