openmrs-module-bahmniapps icon indicating copy to clipboard operation
openmrs-module-bahmniapps copied to clipboard

BAH:488 Fix text overflow in Espanol language

Open manmeet0307 opened this issue 6 years ago • 5 comments

Bahmni EMR login page allow user to choose the language they want to choose ,but language Espanol leads to text overflow.

https://talk.openmrs.org/t/ui-issues-when-language-is-espanol/16427 https://bahmni.atlassian.net/projects/BAH/issues/BAH-488?filter=reportedbyme

manmeet0307 avatar Mar 19 '18 13:03 manmeet0307

@mks-d Is this fine? As it will effect the font size for other languages as well. I am not sure.

ShruthiPitta avatar Apr 05 '18 09:04 ShruthiPitta

I had closed #140 . Can you please review it now.

manmeet0307 avatar Apr 07 '18 08:04 manmeet0307

Actually my set up doesn't work anymore. Therefore I would not be able to share that.

On Fri, 27 Apr 2018, 4:27 p.m. Dimitri R, [email protected] wrote:

@mks-d commented on this pull request.

@manmeet0307 https://github.com/manmeet0307 could you share a before/after screenshot of your changes? On both a problematic case and non-problematic case. That would help assess whether this is acceptable to be merged in for QA testing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bahmni/openmrs-module-bahmniapps/pull/141#pullrequestreview-115897519, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae7G0DlKkmGpMpr3iZgPgKGaG8PpTXYuks5tsvmrgaJpZM4SwLLD .

manmeet0307 avatar Apr 27 '18 11:04 manmeet0307

@manmeet0307, You just reduce the font size. Tomorrow, if someone uses long text, this issue will be back, isn't it?

sumanmaity112 avatar May 12 '18 07:05 sumanmaity112

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 23 '19 12:07 CLAassistant