ChocolateStore icon indicating copy to clipboard operation
ChocolateStore copied to clipboard

feat/resolve dependencies

Open laggingreflex opened this issue 7 years ago • 5 comments

Resolves and downloads dependencies of packages.

Breaking change: Does not accept URL anymore, only package name. Since we're accessing the chocolaty package page anyways, it's easier to just provide package name instead of URL.

Fixes #5

This contains patches I recently submitted in other PRs too (#13, #14), and some minor fixes, so please ignore them and merge this instead (or let me know if I should submit them all separately only)

laggingreflex avatar Feb 16 '18 14:02 laggingreflex

Hi laggingreflex

Thanks for your interest in the project and for your initiative of submitting a pull request! I won't have a chance to have a closer look at this until some time next week.

BahKoo avatar Feb 16 '18 14:02 BahKoo

Hi again.. sorry I haven't been able to review this or give you feedback yet. I'm not sure when I'll get to it but I will. I haven't been active on this project in a while.

BahKoo avatar Feb 27 '18 05:02 BahKoo

A question about the changes in how package urls are resolved: Wouldn't it be better to query the nuget API at https://chocolatey.org/api/v2/Packages/XYZ to download the nuget-file. Extracting the file from the HTML code might break the program in the future if the repository website is redesigned.

sr258 avatar Mar 02 '18 10:03 sr258

Yep, that certainly seems a better option. I'll rework the PR.

laggingreflex avatar Mar 02 '18 10:03 laggingreflex

Great! There are some nuget libraries on nuget. ;) Nuget.Core seems like a good start. A tutorial is here.

I've already gone ahead and done this in my fork of the project. There are quite a lot of other changes in this branch, too, but you'll be able to backport the repository change easily.

sr258 avatar Mar 02 '18 11:03 sr258