Pode.Web icon indicating copy to clipboard operation
Pode.Web copied to clipboard

Published 20 hours ago • verified publisher icon Badgerati

Update Pages.ps1

Open Szeraax opened this issue 1 year ago • 5 comments

Exclude ProgressAction from module pages

Szeraax avatar Feb 15 '24 20:02 Szeraax

Also of note is that there is [System.Management.Automation.PSCmdlet]::OptionalCommonParameters that is also a hashset that you don't currently account for. Do you want to exclude those as well?

Szeraax avatar Feb 17 '24 06:02 Szeraax

Yes, excluding [System.Management.Automation.PSCmdlet]::OptionalCommonParameters as well makes sense :)

Badgerati avatar Feb 20 '24 22:02 Badgerati

Accctually, having WhatIf could be useful, it might be an idea to leave it out as it is today but have a switch parameter to let the user toggle if they want to exclude them.

Badgerati avatar Feb 20 '24 22:02 Badgerati

I agree with everything you stated. Lets ship this PR as is so that Pwsh 7.4 can use pode.web again. and I'll go file an issue to deal with Optional Common Parameters, kk? That's where we can work out switch vs an array of common params to add back in, etc.

Szeraax avatar Feb 21 '24 00:02 Szeraax

WORKAROUND FOUND!! I no longer need v0.8.4+ to continue work on PowerShellAIAssistant! This PR should still be merged though.

Wow, I'm so stupid! And happy :D I should have checked to see if the the ConvertTo-PodeWebPage function actually interacts with module scoped data or if its just a wrapper around big hashtables.

I can just copy this function definition and edit the line to what I want and it works perfectly.

As for the optional common parameters, I'll go file that issue now so that we keep track of it.

Szeraax avatar Feb 23 '24 05:02 Szeraax