BadMagic100

Addressed various review comments/discord discussions in the most recent commit. It would be nice to have unit tests added for the 3 major behavior changes (speculative sweep, sweep for events,...

I had a random thought about this today, from a cleanliness perspective I wonder if it would be desirable to additionally move (or replicate) logicmixin functionality onto player state. My...

This will require a client side change with https://github.com/ArchipelagoMW-HollowKnight/Archipelago.HollowKnight/issues/170

Was this tested without any items links as well?

Client side now supports this goal on the beta builds https://github.com/ArchipelagoMW-HollowKnight/Archipelago.HollowKnight/commit/396610a16fdce6891a48bd999ef8096ec74873ff Slot data must be changed to snake case `grub_count` to work with this change

An observation - grubhunt goal seems to make playthrough very slow. with 5 hks itemlinking grubs + linked replacements playthrough took the better part of a 9min generation

Looks good to me, another quick test on latest commit + the nightly mod would probably be good before sending off for core review, not sure I will get a...

If you have the spoiler log for the any, can we check that it appears correct with the new logic? Otherwise seems good to me

Client support is being released for this, so slot data is locked in now. https://github.com/hk-modding/modlinks/pull/1406

Reading the discussion here I am in agreement with sliver, I think it should be clearly dev only if it is to exist at all (I'm not too convinced it...