handesk Upgrade to 5.6

Upgrade to 5.6

Open 0xairdropfarmer opened this issue 6 years ago • 4 comments

Hello love your project please review my pr

Apr 10 '18 13:04 0xairdropfarmer

Thank you for the PR However I see that the tests are failing both for tests and style ci,

The tests is as simple as just updating the docker container to one with php 7.1 as it is a requirement for larval 5.6

about style CI, I personally like the spaces aligned, and I believe that is why it fails

Do you think you can fix those?

Apr 10 '18 13:04 BadChoice

just a lot of space in PR if you didn't like just close it

Apr 10 '18 15:04 0xairdropfarmer

I really like it, just those spaces thing that will break with the style CI I can do it myself when I get home tought

Apr 10 '18 15:04 BadChoice

Hi @BadChoice,

I think it's easy to fix, just 7 files for StyleCI :D

I know that Laravel Shift is a good service https://laravelshift.com but I think you need test it carefully again before merging it.

Aug 22 '18 06:08 sangnguyenplus