Gert de Pagter comments

Results 64 comments of


                                            Gert de Pagter

Assert::allOneOf get complains from phpStan on usage

@monro93 Can you verify that this is no longer an issue in a newer version?

Warn users about unused configuration parameters

I'm not sure about tooling. One option you could look into is using a configuration class that users can pass into the client. This would make sure it can only...

Trailing slash in host causes issues

Oof its been a while since i made this issue. Currently i'm not using Elastica (or Elasticsearch for that matter) anymore.

Use array_is_list for vec types

Thanks @azjezz !

Add mixed dict and vec types

> What would be the difference between `T\vec(T\mixed())` and `T\mixed_vec()`? Better performance, this won't loop over the entire array if its not needed. Se also https://github.com/azjezz/psl/issues/359

Add mixed dict and vec types

Thanks @azjezz !

feat: Introduce `StaticPrivateMethodFixer`

> Wouldn't running after static lambda relax the first requirement? These two kinda have circular dependency, idk if php-cs-fixer can handle that atm.

feat: Introduce `StaticPrivateMethodFixer`

> must not be declared by interface Interfaces can't declare private methods right?

feat: Introduce `StaticPrivateMethodFixer`

I don't understand, could you provide an example

feat: Introduce `StaticPrivateMethodFixer`

One more possible edge case that (may) not be relevant yet. How about $this etc in php 7.4 arrow functions