Matt Bachmann
Matt Bachmann
Sorry, responded from a work account before. 100% open to a pr on this. I don't typically add features to diff cover myself since I don't actively work on any...
@ptzz in theory that could work. In practice id rather avoid breaking people's workflows. So we would probably want to deprecate the original two options
closing due to inactivity.
So I wrote up a test script to demonstrate this. ``` /Users/redacted/issue ``` As you can see the report basically skips these blank lines. Diff cover is kinda just reporting...
Yep, im still here and do reviews. This is a solo project that I maintain on personal time so I cant promise im always avaliable. But Ill communicate if I...
Reading over the issue it almost sounds like the coverage report was not regenerated after the change? "I think that probably diff-cover ignores lines without coverage report" If a line...
Thanks, ill make some time in the next few days to look at this closely. I starred and cloned the repo.
@m-aciek Ok yeah, I see the issue now. Had to run your example myself and really stare at it for a bit. Im actually somewhat shocked this has not come...
I wonder if the answer here is to report on lines in the diff we could not line up to the report.
I think the next step here is to open an issue with coveragepy and see if they have advise. I recall the SQLite database recently added but I vaguely recall...