BabylonReactNative Shared project and C++Unit Tests

Does it make sense to move this folder/project:

https://github.com/BabylonJS/BabylonReactNative/tree/master/Modules/%40babylonjs/react-native/shared

to BabylonNative repo or a new repo? The goal is to be able to test it using C++ unittests. As it's an integration test, I think it can be done in BabylonNative Unittests. ping @ryantrem @bghgary

Jul 05 '23 12:07 CedricGuillemet

This seems pretty react native specific. Can we introduce unit tests to this repo?

Jul 06 '23 16:07 ryantrem

We can but the issue is the frequency of updates. I'd like to know soon enough when a change is breaking BRN, without the need to kick a build in BRN.

Jul 06 '23 17:07 CedricGuillemet

We have another issue about leveraging DependaBot to create a BRN PR (and potentially PR/CI build) when the BN master branch is updated. Would it make sense to investigate that route?

Jul 06 '23 17:07 ryantrem

I think the DependaBot idea is a different thing. We want to be able to make changes to Babylon Native, build, test without having to know about dependencies. Ideally, we want to be able to test the scenarios that integrations (e.g. React Native) would do to integrate Babylon Native but without the integration code itself. I'm not sure bringing in this code module as a shared component makes sense since the dependency is backwards.

Jul 10 '23 21:07 bghgary

BN CPP UnitTests tests will make sure integration will be fine with BRN. No need to share things between BN and BRN. Closing.

Apr 18 '24 09:04 CedricGuillemet