BabylonReactNative icon indicating copy to clipboard operation
BabylonReactNative copied to clipboard

Added IOS Simulator arm64 binaries to npm packages

Open SergioRZMasson opened this issue 2 years ago • 7 comments

Context

We currently ship @babylonjs/react-native-iosandroid packages with only x86_64 binaries for the IOS Simulator platform. This makes users that consume the package on arm64 MacBook's to be forced to manually modify their Podfile and .xcodeproj to force project to be compiled only for x86_64 Simulator and run under Rossetta. If arm64 binaries were provided I believe everything would work out of the box.

Improvement

Include arm64 IOS Simulator binaries in packages

  • @babylonjs/react-native-iosandroid-64
  • @babylonjs/react-native-iosandroid-65
  • @babylonjs/react-native-iosandroid-69

SergioRZMasson avatar Aug 23 '22 14:08 SergioRZMasson

If I recall I think there is an issue with the way we currently create the libs... we use lipo to merge the x86 and arm libs into a single lib, and the correct architecture is chosen when linking later. However, I believe lipo can't merge two different arm libs (device and simulator). I think we have to switch to an xcframework or something.

ryantrem avatar Aug 23 '22 21:08 ryantrem

@SergioRZMasson would be possible to document here the approach to force the build to work?

lucasff avatar Feb 18 '23 03:02 lucasff

Xcode will stop supporting Rosetta in 14.3, I think this issue will be important for many developers soon: https://developer.apple.com/documentation/xcode-release-notes/xcode-14_3-release-notes

stetbern avatar Mar 13 '23 08:03 stetbern

@bghgary @CedricGuillemet for visibility.

SergioRZMasson avatar Mar 13 '23 17:03 SergioRZMasson

https://forum.babylonjs.com/t/babylonreactnative-building-for-ios-simulator/28506

bghgary avatar Jun 09 '23 00:06 bghgary

Do you happen to have any updates on the adding arm binaries?

ChaimMark avatar Feb 01 '24 23:02 ChaimMark

Do you happen to have any updates on the adding arm binaries?

Sorry, no update yet. But it's still on our radar.

CedricGuillemet avatar Feb 02 '24 09:02 CedricGuillemet