BabylonNative icon indicating copy to clipboard operation
BabylonNative copied to clipboard

Add CMake setting for iOS product bundle identifiers

Open docEdub opened this issue 2 years ago • 3 comments

The iOS product bundle identifiers need to be changed when building locally for development purposes but are hard-coded as "com.BabylonNative.Playground.iOS" and "com.BabylonNative.ValidationTests.iOS".

This change adds CMake settings for the iOS product bundle identifiers so they can be changed without modifying the CMake files directly.

docEdub avatar Aug 11 '22 05:08 docEdub

CLA assistant check
All CLA requirements met.

ghost avatar Aug 11 '22 05:08 ghost

The iOS product bundle identifiers need to be changed when building locally for development purposes

Why? What problem is this solving? Not too familiar with product bundle ids.

ryantrem avatar Aug 11 '22 16:08 ryantrem

The iOS product bundle identifiers need to be changed when building locally for development purposes

Why? What problem is this solving? Not too familiar with product bundle ids.

On my machine I get a bundle id error when building for iOS devices:

error: Failed to register bundle identifier: The app identifier "com.BabylonNative.Playground.iOS" cannot be registered to your development team because it is not available. Change your bundle identifier to a unique string to try again.

Changing the id gets the build working.

docEdub avatar Aug 11 '22 17:08 docEdub

That sounds like something else is wrong. I don't think we need this change.

bghgary avatar Aug 24 '22 17:08 bghgary