Babylon.js icon indicating copy to clipboard operation
Babylon.js copied to clipboard

Remove viewDirectionFactor for GS SH

Open CedricGuillemet opened this issue 1 month ago • 12 comments

CedricGuillemet avatar Dec 08 '25 16:12 CedricGuillemet

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Dec 08 '25 16:12 bjsplat

Snapshot stored with reference name: refs/pull/17544/merge

Test environment: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17544/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/17544/merge https://gui.babylonjs.com/?snapshot=refs/pull/17544/merge https://nme.babylonjs.com/?snapshot=refs/pull/17544/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17544/merge#BCU1XR#0

bjsplat avatar Dec 08 '25 16:12 bjsplat

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat avatar Dec 08 '25 16:12 bjsplat

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat avatar Dec 08 '25 16:12 bjsplat

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat avatar Dec 08 '25 17:12 bjsplat

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat avatar Dec 08 '25 17:12 bjsplat

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Dec 09 '25 15:12 bjsplat

Snapshot stored with reference name: refs/pull/17544/merge

Test environment: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/17544/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/17544/merge https://gui.babylonjs.com/?snapshot=refs/pull/17544/merge https://nme.babylonjs.com/?snapshot=refs/pull/17544/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17544/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

bjsplat avatar Dec 09 '25 15:12 bjsplat

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat avatar Dec 09 '25 15:12 bjsplat

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat avatar Dec 09 '25 15:12 bjsplat

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat avatar Dec 09 '25 15:12 bjsplat

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat avatar Dec 09 '25 15:12 bjsplat

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat avatar Dec 10 '25 09:12 bjsplat

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat avatar Dec 10 '25 09:12 bjsplat

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat avatar Dec 10 '25 09:12 bjsplat

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat avatar Dec 10 '25 09:12 bjsplat

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat avatar Dec 10 '25 09:12 bjsplat

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat avatar Dec 10 '25 10:12 bjsplat

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat avatar Dec 10 '25 10:12 bjsplat

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat avatar Dec 10 '25 10:12 bjsplat

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat avatar Dec 10 '25 10:12 bjsplat

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat avatar Dec 10 '25 10:12 bjsplat

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat avatar Dec 10 '25 10:12 bjsplat

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat avatar Dec 10 '25 11:12 bjsplat

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat avatar Dec 10 '25 11:12 bjsplat

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat avatar Dec 10 '25 11:12 bjsplat

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat avatar Dec 10 '25 11:12 bjsplat

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat avatar Dec 10 '25 12:12 bjsplat

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat avatar Dec 10 '25 16:12 bjsplat

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat avatar Dec 10 '25 17:12 bjsplat