Babylon.js icon indicating copy to clipboard operation
Babylon.js copied to clipboard

Introduce new fluent shared components; conditionally load them from existing shared components if useFluent context is true

Open georginahalpern opened this issue 7 months ago • 84 comments

View shared-ui-components/src/fluent/readme.md for a complete overview of these changes and the plan for rolling them out!

NOTE since the working branch was a combination of inspectorV2 changes and fluent changes, I've created new branch with just the fluent work and combined into a single commit.

There are a lot of files changed but they are scoped to the below categories, with several examples for each. Future PRs will be more incremental, can bring 1 control at a time :)

  • shared-ui-components/src/fluent: contains new primitives and HOCs (including FluentToolWrapper, which wraps children in FluentProvider and ContextProvider<{useFluent=true}> if the 'newUX' QSP is truthy)
  • shared-ui-components/src/lines: existing shared components, updated to conditionally render above fluent components if anywhere upstream is wrapped in a FluentToolWrapper
  • examples enabling fluent in the below tools
    • packages/tools/nodeEditor/src/graphEditor.tsx (NME)
    • packages/dev/inspector/src/components/actionTabs/tabs/propertyGridTabComponent.tsx (inspectorV1 property panel)
    • shared-ui-components/src/fluent/tempInspectorV2 (temp folder to show usage before ryan's changes are merged - u can view them in PR history but won't be checked in with the final merge)
      • packages/dev/inspector-v2/src/services/panes/properties/mesh/meshGeneralProperties.tsx
      • packages/dev/inspector-v2/src/services/panes/properties/mesh/meshOutlineOverlayProperties.tsx
      • packages/dev/inspector-v2/src/services/panes/properties/mesh/meshTransformProperties.tsx

georginahalpern avatar Jun 03 '25 15:06 georginahalpern

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Jun 03 '25 15:06 bjsplat

Reviewer - this PR has made changes to one or more package.json files.

bjsplat avatar Jun 03 '25 15:06 bjsplat

Building or testing the sandbox has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 03 '25 16:06 bjsplat

Building or testing the playground has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 03 '25 16:06 bjsplat

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 03 '25 16:06 bjsplat

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Jun 03 '25 17:06 bjsplat

Reviewer - this PR has made changes to one or more package.json files.

bjsplat avatar Jun 03 '25 17:06 bjsplat

Building or testing the sandbox has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 03 '25 17:06 bjsplat

Building or testing the playground has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 03 '25 17:06 bjsplat

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 03 '25 17:06 bjsplat

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Jun 04 '25 16:06 bjsplat

Reviewer - this PR has made changes to one or more package.json files.

bjsplat avatar Jun 04 '25 16:06 bjsplat

Building or testing the playground has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 04 '25 16:06 bjsplat

Building or testing the sandbox has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 04 '25 16:06 bjsplat

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 04 '25 17:06 bjsplat

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Jun 04 '25 23:06 bjsplat

Reviewer - this PR has made changes to one or more package.json files.

bjsplat avatar Jun 04 '25 23:06 bjsplat

Building or testing the sandbox has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 04 '25 23:06 bjsplat

Building or testing the playground has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 04 '25 23:06 bjsplat

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 04 '25 23:06 bjsplat

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Jun 05 '25 00:06 bjsplat

Reviewer - this PR has made changes to one or more package.json files.

bjsplat avatar Jun 05 '25 00:06 bjsplat

Building or testing the playground has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 05 '25 00:06 bjsplat

Building or testing the sandbox has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 05 '25 00:06 bjsplat

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 05 '25 00:06 bjsplat

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Jun 05 '25 01:06 bjsplat

Reviewer - this PR has made changes to one or more package.json files.

bjsplat avatar Jun 05 '25 01:06 bjsplat

Building or testing the sandbox has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 05 '25 01:06 bjsplat

Building or testing the playground has failed.

If the tests failed, results can be found here: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 05 '25 01:06 bjsplat

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16709/merge/testResults/

bjsplat avatar Jun 05 '25 01:06 bjsplat