Babylon.js icon indicating copy to clipboard operation
Babylon.js copied to clipboard

Enable alpha test when using vertex alpha in some cases

Open bghgary opened this issue 1 year ago • 7 comments

This change addresses some edge cases tested by a new test model in the glTF sample assets repo: https://github.com/KhronosGroup/glTF-Sample-Assets/pull/146.

The issue is that alpha test is not taking into account whether a mesh has vertex alpha or not.

Before: image

After: image

TODO

  • [ ] Add test once new test model is merged

bghgary avatar Aug 30 '24 16:08 bghgary

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Aug 30 '24 16:08 bjsplat

Snapshot stored with reference name: refs/pull/15504/merge

Test environment: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15504/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15504/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15504/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/15504/merge https://gui.babylonjs.com/?snapshot=refs/pull/15504/merge https://nme.babylonjs.com/?snapshot=refs/pull/15504/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15504/merge#BCU1XR#0

bjsplat avatar Aug 30 '24 16:08 bjsplat

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15504/merge/testResults/webgl2playwright/index.html

bjsplat avatar Aug 30 '24 16:08 bjsplat

Visualization tests for WebGPU (Experimental)

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15504/merge/testResults/webgpuplaywright/index.html

bjsplat avatar Aug 30 '24 16:08 bjsplat

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15504/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

bjsplat avatar Sep 05 '24 00:09 bjsplat

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15504/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

bjsplat avatar Sep 05 '24 10:09 bjsplat

This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale".

github-actions[bot] avatar Oct 04 '24 00:10 github-actions[bot]

Closing in favor of #15573

bghgary avatar Oct 28 '24 20:10 bghgary