Babylon.js icon indicating copy to clipboard operation
Babylon.js copied to clipboard

WebDeviceInputSystem: Removed move handling code from _pointerDownEvent

Open PolygonalSun opened this issue 2 years ago • 2 comments

In the WebDeviceInputSystem, when we receive a pointerdown event, we will call the observers associated with down events (from within _pointerDownEvent) and then call the ones associated with move. After looking more closely at this, I believe that we do not need to do this as the pointer position will still be updated in the InputManager's down code. This PR removes this move call from the code that handled the pointerdown events.

PolygonalSun avatar Dec 20 '23 23:12 PolygonalSun

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat avatar Dec 20 '23 23:12 bjsplat

Snapshot stored with reference name: refs/pull/14637/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14637/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14637/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/14637/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/14637/merge https://gui.babylonjs.com/?snapshot=refs/pull/14637/merge https://nme.babylonjs.com/?snapshot=refs/pull/14637/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/14637/merge#BCU1XR#0

bjsplat avatar Dec 20 '23 23:12 bjsplat

This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale".

github-actions[bot] avatar Mar 14 '24 00:03 github-actions[bot]

This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale".

github-actions[bot] avatar Mar 30 '24 00:03 github-actions[bot]

Closing for now. Will reevaluate later

PolygonalSun avatar Apr 04 '24 18:04 PolygonalSun