Babylon.js icon indicating copy to clipboard operation
Babylon.js copied to clipboard

Fix scene serialization and loading issues.

Open carolhmj opened this issue 3 years ago • 4 comments

Related forum issue: https://forum.babylonjs.com/t/importing-mesh-loses-hierarchy/32779

When we parse a mesh, the parentId from the JSON probably won't be the same as the uniqueId of the recreated parent, so keep a mapping to properly find this recreated parent.

carolhmj avatar Aug 09 '22 20:08 carolhmj

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 09 '22 20:08 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12856/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12856/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12856/merge https://gui.babylonjs.com/?snapshot=refs/pull/12856/merge https://nme.babylonjs.com/?snapshot=refs/pull/12856/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12856/merge#BCU1XR#0

azure-pipelines[bot] avatar Aug 09 '22 21:08 azure-pipelines[bot]

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

azure-pipelines[bot] avatar Aug 09 '22 21:08 azure-pipelines[bot]

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

azure-pipelines[bot] avatar Aug 09 '22 21:08 azure-pipelines[bot]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 10 '22 15:08 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12856/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12856/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12856/merge https://gui.babylonjs.com/?snapshot=refs/pull/12856/merge https://nme.babylonjs.com/?snapshot=refs/pull/12856/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12856/merge#BCU1XR#0

azure-pipelines[bot] avatar Aug 10 '22 16:08 azure-pipelines[bot]

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

azure-pipelines[bot] avatar Aug 10 '22 16:08 azure-pipelines[bot]

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

azure-pipelines[bot] avatar Aug 10 '22 16:08 azure-pipelines[bot]

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

azure-pipelines[bot] avatar Aug 10 '22 19:08 azure-pipelines[bot]

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

azure-pipelines[bot] avatar Aug 10 '22 19:08 azure-pipelines[bot]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 11 '22 10:08 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12856/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12856/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12856/merge https://gui.babylonjs.com/?snapshot=refs/pull/12856/merge https://nme.babylonjs.com/?snapshot=refs/pull/12856/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12856/merge#BCU1XR#0

azure-pipelines[bot] avatar Aug 11 '22 11:08 azure-pipelines[bot]

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

azure-pipelines[bot] avatar Aug 11 '22 11:08 azure-pipelines[bot]

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

azure-pipelines[bot] avatar Aug 11 '22 11:08 azure-pipelines[bot]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines[bot] avatar Aug 11 '22 15:08 azure-pipelines[bot]

Snapshot stored with reference name: refs/pull/12856/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12856/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12856/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/12856/merge https://gui.babylonjs.com/?snapshot=refs/pull/12856/merge https://nme.babylonjs.com/?snapshot=refs/pull/12856/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12856/merge#BCU1XR#0

azure-pipelines[bot] avatar Aug 11 '22 15:08 azure-pipelines[bot]