Babylon.js icon indicating copy to clipboard operation
Babylon.js copied to clipboard

Make sure to log shader compilation error better in validation tests

Open RaananW opened this issue 2 years ago • 1 comments

If a shader compilation occurs it currently shows the full log but halts and doesn't report the error.

Make sure shader compilation errors are reported and (if possible) add a comment with the failed playground for the dev/reviewer to use.

See https://dev.azure.com/babylonjs/ContinousIntegration/_build/results?buildId=19143&view=logs&j=71a83ec6-a99b-56a2-aed7-297b94c4e57e&t=d751f905-fa52-5e6b-98c6-70fa16fc81f1

RaananW avatar Mar 23 '22 10:03 RaananW

Moving to playwright - #12977 - will allow us to get the console output without any issues on both firefox and chromium. THis issue is suspended until migration to playwright is done

RaananW avatar Sep 13 '22 10:09 RaananW

Closing as no request. Feel free to re-open if needed

thomlucc avatar May 16 '23 17:05 thomlucc