Burak Yigit Kaya
Burak Yigit Kaya
We deprecated custom integrations so closing.
This change looks a bit invasive. Do we really need a `skipSidecar` option? Like how about we pass `sidecarUrl: false` or even better, we just say we cannot connect to...
@mydea I'll explore ways to do this automatically rather than using an explicit flag. That's why I'm keeping the PR open but I don't think we'll be moving forward with...
We are going in a direction where Spotlight is sidecar-first so closing this PR as not planned. Relevant ticket #891
I think we should wrap tab generation code from integrations into a `useMemo` here: https://github.com/getsentry/spotlight/blob/6aea29bd34b836e86e08ceb040003cb8cb89f622/packages/overlay/src/components/Overview.tsx#L20-L29 I tried that but using `integrationData` as the dependencies for `useMemo` doesn't really work as...
Looks like it might be time for us to use an established data layer for our React app instead of rolling our own. @Shubhdeep12 suggested using zustand and it looks...
@Shubhdeep12 oh, so you are saying we need to refactor how we do integrations. That actually makes sense. We probably need to allow them to pass a "on data updated"...
Okay, we need to use this for SQL highlighting: https://sentry.engineering/blog/formatting-sql-on-the-frontend That means we need to extract that code into its own package and I got the go from @gggritso for...
/cc @betegon
I think @MathurAditya724 made this happen in #999