rend3
rend3 copied to clipboard
Added an orbit cam using Dolly to the Scene Viewer
Checklist
- CI Checked:
- [x ]
cargo fmt
has been ran - [ ]
cargo clippy
reports no issues
- [x ]
Checking bimap v0.6.3
error: incorrect implementation of `clone` on a `Copy` type
--> rend3-types/src/lib.rs:59:29
|
59 | fn clone(&self) -> Self {
| _____________________________^
60 | | Self {
61 | | idx: self.idx,
62 | | _phantom: PhantomData,
63 | | }
64 | | }
| |_____^ help: change this to: `{ *self }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_clone_impl_on_copy_type
= note: `#[deny(clippy::incorrect_clone_impl_on_copy_type)]` on by default
- [x]
cargo test
succeeds - [x]
cargo rend3-doc
has no warnings - [ ]
cargo deny check
issues have been fixed or added to deny.toml
warning[unmatched-skip-root]: skip tree root was not found in the dependency graph
┌─ /Users/andy/rust/rend3d/rend3/deny.toml:29:5
│
29 │ { name = "loom", version = "0.5" },
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate matched these criteria
warning[license-not-encountered]: license was not encountered
┌─ /Users/andy/rust/rend3d/rend3/deny.toml:4:42
│
4 │ allow = ["Apache-2.0", "MIT", "MPL-2.0", "LicenseRef-UFL-1.0", "Unlicense"]
│ ^^^^^^^^^^^^^^^^^^^^ unmatched license allowance
- Manually Checked:
- [ ] relevant examples/test cases run
- [ ] changes added to changelog
- [ ] Add credit to yourself for each change:
Added new functionality @githubname
. - [ ]
- [ ] Add credit to yourself for each change:
Suggestion:
Added an orbit cam using the Dolly crate to the Scene Viewer @apps4uco
Related Issues
#307
Description
Added an orbit cam using Dolly to the Scene Viewer @apps4uco.
Keys:
W Forward S Back A Left D Right Q Up Z Down
Note: Mouse movement is supported but a bit jerky
Tested with default sample and https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/ABeautifulGame
This is awesome! Might take me a day or so to review this, but I've wanted to integrate dolly for a while!
By the way I am happy to work on this functionality more e.g.: to implement other types of cameras if you would like.
Sorry for the massive delay in getting back to this.
This is a good first start! It's actually not a bad way of navigating. My thoughts so far:
- It would be nice if wasdqz still moved the center of the camera, and mouse + mousewheel did orbit size. I think that would be a more natural way to explore spaces
- The sensitivity of the mouse seems way high