MnB2-Bannerlord-CommunityPatch icon indicating copy to clipboard operation
MnB2-Bannerlord-CommunityPatch copied to clipboard

Land Tax does not do anything at all

Open variableundefined opened this issue 4 years ago • 2 comments

The method CalculateDailyTax

		private float CalculateDailyTax(Town town, ref ExplainedNumber explainedNumber)
		{
			float prosperity = town.Prosperity;
			float num = 1f;
			if (town.Settlement.OwnerClan.Kingdom != null && town.Settlement.OwnerClan.Kingdom.ActivePolicies.Contains(DefaultPolicies.LandTax))
			{
				num += 0.05f;
			}
			int num2 = (int)(prosperity * 0.2f);
			explainedNumber.Add((float)num2, this._prosperityText);
			return explainedNumber.ResultNumber;
		}

Doesn't apply num to the return value, so land tax does not work at all

variableundefined avatar Apr 18 '20 18:04 variableundefined

What version of the game is that?

    private float CalculateDailyTax(Town town, ref ExplainedNumber explainedNumber)
    {
      double prosperity = (double) town.Prosperity;
      float num1 = 1f;
      if (town.Settlement.OwnerClan.Kingdom != null && town.Settlement.OwnerClan.Kingdom.ActivePolicies.Contains(DefaultPolicies.LandTax))
      {
        float num2 = num1 + 0.05f;
      }
      int num3 = (int) (prosperity * 0.200000002980232);
      explainedNumber.Add((float) num3, this._prosperityText);
      return explainedNumber.ResultNumber;
    }

This one is from the beta branch, e1.2.0. The method has been changed for some reason, but they still forgot to wire it up. ¯\(ツ)

Skau avatar Apr 18 '20 19:04 Skau

e1.1.0

variableundefined avatar Apr 18 '20 19:04 variableundefined