MnB2-Bannerlord-CommunityPatch icon indicating copy to clipboard operation
MnB2-Bannerlord-CommunityPatch copied to clipboard

Diplomatic barters with the player's clan including prisoner exchanges don't require player input

Open TYoung86 opened this issue 4 years ago • 2 comments

Need to investigate TaleWorlds.CampaignSystem.SandBox.CampaignBehaviors.BarterBehaviors.DiplomaticBartersBehavior and see where we'd ask for the player's input.

TYoung86 avatar Apr 14 '20 23:04 TYoung86

We should try to make sure not to cause compatibility issues with this mod; https://www.nexusmods.com/mountandblade2bannerlord/mods/134

Aberro has more enhancements in there than we should try to provide. We also probably don't want to interfere with escape mechanics.

TYoung86 avatar Apr 14 '20 23:04 TYoung86

If you'd just call CampaignEvents.DailyTickHeroEvent.ClearListeners(Campaign.Current.GetCampaignBehavior<DiplomaticBartersBehavior>()); then it should be safe, as it's same thing I do. So, if my mod will try to clear listeners too, it will be ok. Though, you may consider overriding original method just making sure that captor is not a player. But that could cause compatibility issue with my mod, as I've overriden prisoner barter.

Aberro avatar Apr 14 '20 23:04 Aberro