BTCP-Rebase icon indicating copy to clipboard operation
BTCP-Rebase copied to clipboard

[wallet] [zk] Properly introduce UpdateNullifierNoteMap(WithTx) to AddToWallet

Open ch4ot1c opened this issue 6 years ago • 2 comments

Zcash: https://github.com/zcash/zcash/blob/13b41a6760c67524dd77afc67e7d556ec1ea71be/src/wallet/wallet.cpp#L1114 bool CWallet::AddToWallet(const CWalletTx& wtxIn, bool fFromLoadWallet, CWalletDB* pwalletdb);

https://github.com/zcash/zcash/blob/13b41a6760c67524dd77afc67e7d556ec1ea71be/src/wallet/wallet.cpp#L1263 bool AddToWalletIfInvolvingMe(const CTransactionRef& tx, const CBlockIndex* pIndex, int posInBlock, bool fUpdate) EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);

Bitcoin signatures: bool AddToWallet(const CWalletTx& wtxIn, bool fFlushOnClose=true); bool AddToWalletIfInvolvingMe(const CTransactionRef& tx, const CBlockIndex* pIndex, int posInBlock, bool fUpdate) EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

ch4ot1c avatar Jul 21 '18 20:07 ch4ot1c

#35 puts us on track for this change

ch4ot1c avatar Jul 21 '18 20:07 ch4ot1c

IncOrderPosNext takes a WalletDB in Zcash, but WalletBatch in Bitcoin.

ch4ot1c avatar Oct 02 '18 15:10 ch4ot1c